pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #3650: Use less aggressive JVM memory settings in default config file
Date Fri, 22 Feb 2019 02:28:11 GMT
merlimat commented on a change in pull request #3650: Use less aggressive JVM memory settings
in default config file
URL: https://github.com/apache/pulsar/pull/3650#discussion_r259193787
 
 

 ##########
 File path: conf/bkenv.sh
 ##########
 @@ -33,10 +33,13 @@ BOOKIE_CONF=${BOOKIE_CONF:-"$BK_HOME/conf/bookkeeper.conf"}
 # BOOKIE_LOG_DIR=
 
 # Memory size options
-BOOKIE_MEM=" -Xms2g -Xmx2g -XX:MaxDirectMemorySize=2g"
+BOOKIE_MEM=" -Xmx2g -XX:MaxDirectMemorySize=2g -XX:+ExitOnOutOfMemoryError"
 
 # Garbage collection options
-BOOKIE_GC=" -XX:+UseG1GC -XX:MaxGCPauseMillis=10 -XX:+ParallelRefProcEnabled -XX:+UnlockExperimentalVMOptions
-XX:+AggressiveOpts -XX:+DoEscapeAnalysis -XX:ParallelGCThreads=32 -XX:ConcGCThreads=32 -XX:G1NewSizePercent=50
-XX:+DisableExplicitGC -XX:-ResizePLAB"
+BOOKIE_GC=" -XX:+UseG1GC"
 
 Review comment:
   To give context, these flags were the settings we were using in a very particular hardware
configuration in production. They work well in prod/performance scenarios in that configuration
but they probably don't work that well in any other slightly different configuration. 
   
   Default should indeed be more conservative and work reasonably well under most conditions.
It might not be super-tuned for low-latency or high throughput, and we can give some guidelines
in documentation around that, but if one cares about some performance aspect, he would have
to test anyway in its own environment anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message