pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #3622: add reset cousor to a specific message time
Date Thu, 21 Feb 2019 02:55:48 GMT
sijie commented on a change in pull request #3622: add reset cousor to a specific message time
URL: https://github.com/apache/pulsar/pull/3622#discussion_r258552918
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
 ##########
 @@ -1075,6 +1074,21 @@ protected void handleSeek(CommandSeek seek) {
                         "Error when resetting subscription: " + ex.getCause().getMessage()));
                 return null;
             });
+        } else if (consumerFuture != null && consumerFuture.isDone() && !consumerFuture.isCompletedExceptionally()
&& seek.hasMessageTime()){
 
 Review comment:
   ```suggestion
           } else if (consumerCreated && seek.hasMessageTime()) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message