pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ConcurrencyPractitioner commented on a change in pull request #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation
Date Wed, 20 Feb 2019 16:37:52 GMT
ConcurrencyPractitioner commented on a change in pull request #3625: [Issue #3436][pulsar-broker]
Creating REST Endpoint for non-partitioned topic creation
URL: https://github.com/apache/pulsar/pull/3625#discussion_r258569762
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
 ##########
 @@ -398,6 +398,18 @@ protected void internalCreatePartitionedTopic(int numPartitions, boolean
authori
         }
     }
 
+    protected void internalCreateNonPartitionedTopic(boolean authoritative) {
+    	validateAdminAccessForTenant(topicName.getTenant());
+    	
+    	try {
+    		PersistentTopic topic = (PersistentTopic) getOrCreateTopic(topicName);
+    		//...
 
 Review comment:
   Sorry about that, that was meant to denote that there should be some lines of code below
it. (which I will probably add later)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message