pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation
Date Wed, 20 Feb 2019 11:38:50 GMT
sijie commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned
topic creation
URL: https://github.com/apache/pulsar/pull/3625#issuecomment-465539620
 
 
   > A non-partitioned topic is created in `internalCreateSubscription`, but functions
as a temporary topic from which a subscription could be created. So if we created a non-partitioned
PersistentTopic outside of this method, what would we do with it?
   
   Currently the default behavior is a non-partitioned topic automatically created when a
consumer subscribe or a publisher publishes a message. With you previous change, we disable
this auto-creation. so the endpoint is the only way to create the non-partitioned topic. If
a topic is created by the rest endpoint, when consumer/publisher connect, they will be realizing
that the topic has been created. they will continue consuming or publishing messages.
   
   > I remember that `createPartitionedTopic` needed to be improved. I noticed that there
is a precondition which prevents the number of partitions from being created to be less than
two. So my understanding here is that we should remove this condition (i.e. allow the creation
of a topic with no partitions) ?
   
   I think that should be a different pull request and a separated discussion. Changing the
behavior of creating partitioned topic (e.g. allow creating a partitioned topic with only
1 partition) should be discussed at dev@ mailing list. It should be done via a PIP, since
it is a user facing behavior change though.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message