pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jai1 commented on a change in pull request #3627: Pulsar Startup Script fixes to provide custom conf files for bookie s…
Date Wed, 20 Feb 2019 08:19:20 GMT
jai1 commented on a change in pull request #3627: Pulsar Startup Script fixes to provide custom
conf files for bookie s…
URL: https://github.com/apache/pulsar/pull/3627#discussion_r258372787
 
 

 ##########
 File path: bin/pulsar
 ##########
 @@ -221,7 +221,6 @@ fi
 
 if [ -z "$PULSAR_GLOBAL_ZK_CONF" ]; then
     PULSAR_GLOBAL_ZK_CONF=$DEFAULT_GLOBAL_ZK_CONF
-    PULSAR_CONFIGURATION_STORE_CONF=$DEFAULT_GLOBAL_ZK_CONF
 
 Review comment:
   > While running `bin/pulsar configuration-store` the script overrides the custom conf
file with default if `PULSAR_GLOBAL_ZK_CONF` is not provided.
   
   This change fixes this ^^
   
   For example, try running 
   ```
   export PULSAR_CONFIGURATION_STORE_CONF=<custom path>
   bin/pulsar configuration-store
   ```
   
   The DEFAULT_GLOBAL_ZK_CONF will be picked up instead of your custom file.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message