pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on issue #3602: Build docker images from directories instead of tgz files
Date Fri, 15 Feb 2019 18:28:55 GMT
merlimat commented on issue #3602: Build docker images from directories instead of tgz files
URL: https://github.com/apache/pulsar/pull/3602#issuecomment-464151453
 
 
   > This is not needed we need to use a multi stage docker file which is more efficient
and the recommended way.
   
   @aahmed-se  That's a different issue
   
   >  what is the before and after size?
   
   we're cutting in half the size of pulsar distribution (which is ~286MB).
   
   The problem with using the tgz is that we have 2 operations: 
   ```
   ADD ${PULSAR_TARBALL} /	
   RUN mv /apache-pulsar-* /pulsar
   ```
   
   The `mv` operation is creating a new additional layer with a copy of the directory.
   
   BTW, integration tests are failing because the maven resource plugin is messing up with
the execution bit while copying the scripts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message