pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] cckellogg commented on a change in pull request #3606: [Issue 3590] [broker] Support to get broker server runtime configuration
Date Fri, 15 Feb 2019 16:45:10 GMT
cckellogg commented on a change in pull request #3606: [Issue 3590] [broker] Support to get
broker server runtime configuration
URL: https://github.com/apache/pulsar/pull/3606#discussion_r257309298
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
 ##########
 @@ -1336,6 +1337,13 @@ public void onUpdate(String path, Map<String, String> data,
Stat stat) {
         return dynamicConfigurationMap.keys();
     }
 
+    public List<String> getRuntimeConfiguration() {
 
 Review comment:
   Should this return a map instead of a list? Or maybe should the values be sorted so it's
easier to read with printing from the cli?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message