pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #3568: Refresh Certs every X minutes
Date Wed, 13 Feb 2019 23:47:11 GMT
merlimat commented on a change in pull request #3568: Refresh Certs every X minutes
URL: https://github.com/apache/pulsar/pull/3568#discussion_r256638780
 
 

 ##########
 File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/AuthenticationDataProvider.java
 ##########
 @@ -40,6 +40,22 @@
     default boolean hasDataForTls() {
         return false;
     }
+    
+    /**
+     * 
+     * @return a Client Certificate File Path, or null if data is not available
+     */
+    default String getCertFilePath() {
 
 Review comment:
   Again, I don't think it's a good option to have these 2 here, since the auth data provider
is not specific to TLS.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message