pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #3588: [go client] add SubscriptionInitPos option in ConsumerOptions
Date Wed, 13 Feb 2019 04:31:52 GMT
merlimat commented on a change in pull request #3588: [go client] add SubscriptionInitPos option
in ConsumerOptions
URL: https://github.com/apache/pulsar/pull/3588#discussion_r256244479
 
 

 ##########
 File path: pulsar-client-go/pulsar/consumer.go
 ##########
 @@ -77,6 +86,9 @@ type ConsumerOptions struct {
 	// Default is `Exclusive`
 	Type SubscriptionType
 
+	// Default is `Latest`
 
 Review comment:
   Comment should indicate what is the purpose of setting a `SubscriptionInitPos`, eg: "If
the subscription does not exist, it will be created either pointing at the end of the topic
(`Latest`, which is the default) or on the earliest available message `Earliest`)"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message