pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #3450: Adding configuration to disable auto-topic creation
Date Wed, 13 Feb 2019 02:05:50 GMT
sijie commented on a change in pull request #3450: Adding configuration to disable auto-topic
creation
URL: https://github.com/apache/pulsar/pull/3450#discussion_r256222821
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
 ##########
 @@ -459,11 +459,17 @@ public void unloadNamespaceBundlesGracefully() {
     }
 
     public CompletableFuture<Optional<Topic>> getTopicIfExists(final String topic)
{
-        return getTopic(topic, false /* createIfMissing */);
+        return getTopic(topic, false /* use allowAutoTopicCreation */);
 
 Review comment:
   oh I see. so the comment of the flag here is wrong, no?
   
   it should be `/* createIfMissing */`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message