pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rdhabalia commented on a change in pull request #3543: [pulsar-common] add option that field can be empty
Date Sun, 10 Feb 2019 07:35:45 GMT
rdhabalia commented on a change in pull request #3543: [pulsar-common] add option that field
can be empty
URL: https://github.com/apache/pulsar/pull/3543#discussion_r255326297
 
 

 ##########
 File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/FieldContext.java
 ##########
 @@ -87,5 +87,12 @@
      * @return true if the setting is deprecated, otherwise false.
      */
     boolean deprecated() default false;
+    
+    /**
+     * Can field be empty if value not present into config/property file
+     * 
+     * @return
+     */
+    boolean canEmpty() default false;
 
 Review comment:
   yes.. that's good idea.. I fixed it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message