pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] massakam commented on issue #3550: Create SSL context in constructor of ChannelInitializer
Date Sat, 09 Feb 2019 15:54:21 GMT
massakam commented on issue #3550: Create SSL context in constructor of ChannelInitializer
URL: https://github.com/apache/pulsar/pull/3550#issuecomment-462055492
 
 
   @merlimat With this modification, broker now loads a private key and certificates at startup.
Therefore, if `brokerServicePortTls` is set but `tlsKeyFilePath` and `tlsCertificateFilePath`
are not set, the broker fails to start.
   
   Initially, I modified `MockedPulsarServiceBaseTest` to set a private key and a certificate,
but it seems that the test classes in other submodules that inherit this class fail to read
those files.
   
   So deleted setting of the ports to be used for TLS from `MockedPulsarServiceBaseTest` and
set them only in the tests that need to enable TLS.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message