pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rdhabalia commented on a change in pull request #3501: [pulsar-broker] Make non-tls web/broker-service optional
Date Thu, 07 Feb 2019 20:28:53 GMT
rdhabalia commented on a change in pull request #3501: [pulsar-broker] Make non-tls web/broker-service
optional
URL: https://github.com/apache/pulsar/pull/3501#discussion_r254855764
 
 

 ##########
 File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
 ##########
 @@ -101,7 +101,7 @@
         category = CATEGORY_SERVER,
         doc = "The port for serving binary protobuf requests"
     )
-    private Integer brokerServicePort = 6650;
+    private Integer brokerServicePort;
 
 Review comment:
   then right now, [as we can see in this test](https://github.com/apache/pulsar/blob/be20d32406f0f72d8cb21ce964b76e65bf604695/pulsar-broker-common/src/test/java/org/apache/pulsar/common/configuration/PulsarConfigurationLoaderTest.java#L103),
`PulsarConfigurationLoader` doesn't update the field and broker considers default field value
so, it will be always 8080 if we keep `private Integer brokerServicePort = 6650;`.  let me
check if we can make change at `PulsarConfigurationLoader` where it sets field value null
if value is not provided in config file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message