pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] 1m2c3t4 opened a new pull request #3531: fix some LGTM alerts
Date Wed, 06 Feb 2019 14:52:21 GMT
1m2c3t4 opened a new pull request #3531: fix some LGTM alerts
URL: https://github.com/apache/pulsar/pull/3531
 
 
   
   ### Motivation
   
   LGTM has raised some alerts during analysis of apache/pulsar (https://lgtm.com/projects/g/apache/pulsar/alerts/?mode=tree).
   
   ### Modifications
   
   - Fixed 1 `Array index out of bounds` error in AbstractMetrics
   - Fixed 3 cases of `Hashed value without hashCode definition` in NamespaceService
   - Fixed 1 `Reference equality test of boxed types` in Policies
   - Fixed 1 `Wrong NaN comparison` in ProducerStatsRecorderImpl
   - Fixed 16 cases of `Inconsistent equals and hashCode` where equals had been overridden
but hashCode was not
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API: ( no)
     - The schema: ( no )
     - The default values of configurations: (no)
     - The wire protocol: ( no)
     - The rest endpoints: (no)
     - The admin cli options: ( no)
     - Anything that affects deployment: (no )
   
   ### Documentation
   
     - Does this pull request introduce a new feature? ( no)
     
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message