pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ConcurrencyPractitioner edited a comment on issue #3450: Adding configuration to disable auto-topic creation
Date Wed, 06 Feb 2019 06:13:24 GMT
ConcurrencyPractitioner edited a comment on issue #3450: Adding configuration to disable auto-topic
creation
URL: https://github.com/apache/pulsar/pull/3450#issuecomment-460911394
 
 
   Thanks for the pointers. Just wanting to confirm, is it the community version or the licensed
version?
   
   Also, I did some work on ```PersistentTopicsTest``` and attempted to add a new test.
   Here's basically what it did:
   ```
       	final String nonPartitionTopic = "nonPartitionedTopic";
       	persistentTopics.createSubscription(testTenant, testNamespace, nonPartitionTopic,
"test", true, (MessageIdImpl) MessageId.latest);
       	List<String> subscriptions =  persistentTopics.getSubscriptions(testTenant,
testNamespace, nonPartitionTopic + "-partition-0", true);
           Assert.assertTrue(subscriptions.contains("test"));
           persistentTopics.deleteSubscription(testTenant, testNamespace, nonPartitionTopic,
"test", true);
           subscriptions =  persistentTopics.getSubscriptions(testTenant, testNamespace, nonPartitionTopic
+ "-partition-0", true);
           Assert.assertTrue(subscriptions.isEmpty());  
   ```
   I also modified the config value i.e. ```pulsar.getConfiguration().setAllowAutoTopicCreation(false)```
   
   WDYT of this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message