pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #3525: WIP - [Issue 3458: Tag Pulsar ledgers in order to distinguish from other leggers in the same Bookkeeper cluster
Date Tue, 05 Feb 2019 20:34:48 GMT
merlimat commented on a change in pull request #3525: WIP - [Issue 3458: Tag Pulsar ledgers
in order to distinguish from other leggers in the same Bookkeeper cluster
URL: https://github.com/apache/pulsar/pull/3525#discussion_r254034788
 
 

 ##########
 File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
 ##########
 @@ -3013,13 +3018,17 @@ public static ManagedLedgerException createManagedLedgerException(Throwable
t) {
      * @param config
      * @param digestType
      * @param cb
-     * @param emptyMap
+     * @param metadata
      */
     protected void asyncCreateLedger(BookKeeper bookKeeper, ManagedLedgerConfig config, DigestType
digestType,
-            CreateCallback cb, Map<Object, Object> emptyMap) {
+            CreateCallback cb, Map<String, byte[]> metadata) {
         AtomicBoolean ledgerCreated = new AtomicBoolean(false);
+        Map<String, byte[]> finalMetadata = new HashMap<>();
+        finalMetadata.putAll(ledgerMetadata);
+        finalMetadata.putAll(metadata);
+        log.info("creating ledger, metadata: "+finalMetadata);
 
 Review comment:
   This could be debug log

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message