pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #3514: Introduce batched sink interface
Date Tue, 05 Feb 2019 02:54:27 GMT
jerrypeng commented on a change in pull request #3514: Introduce batched sink interface
URL: https://github.com/apache/pulsar/pull/3514#discussion_r253722408
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
 ##########
 @@ -403,6 +412,35 @@ void processArguments() throws Exception {
                 sinkConfig.setResources(resources);
             }
 
+            // window configs
+            WindowConfig windowConfig = sinkConfig.getWindowConfig();
+            if (null != windowLengthCount) {
+                if (windowConfig == null) {
+                    windowConfig = new WindowConfig();
+                }
+                windowConfig.setWindowLengthCount(windowLengthCount);
+            }
+            if (null != windowLengthDurationMs) {
+                if (windowConfig == null) {
+                    windowConfig = new WindowConfig();
+                }
+                windowConfig.setWindowLengthDurationMs(windowLengthDurationMs);
+            }
+            if (null != slidingIntervalCount) {
 
 Review comment:
   I don't think we should have sliding windows for batched sink.  What would be the use case
for that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message