pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rdhabalia commented on a change in pull request #3501: [pulsar-broker] Make non-tls web/broker-service optional
Date Fri, 01 Feb 2019 19:53:01 GMT
rdhabalia commented on a change in pull request #3501: [pulsar-broker] Make non-tls web/broker-service
optional
URL: https://github.com/apache/pulsar/pull/3501#discussion_r253179439
 
 

 ##########
 File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
 ##########
 @@ -101,7 +101,7 @@
         category = CATEGORY_SERVER,
         doc = "The port for serving binary protobuf requests"
     )
-    private Integer brokerServicePort = 6650;
+    private Integer brokerServicePort;
 
 Review comment:
   > Wouldn't this disable the "clear-text" service by default?
   
   yes. with this change, "clear-text" will disable the service.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message