From commits-return-21395-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Tue Jan 29 03:09:11 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AE66318067A for ; Tue, 29 Jan 2019 03:09:10 +0100 (CET) Received: (qmail 61495 invoked by uid 500); 29 Jan 2019 02:09:09 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 61486 invoked by uid 99); 29 Jan 2019 02:09:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Jan 2019 02:09:09 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] jerrypeng commented on a change in pull request #3468: Add a component tag for every pulsar function Message-ID: <154872774921.20589.4921462153726186077.gitbox@gitbox.apache.org> Date: Tue, 29 Jan 2019 02:09:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jerrypeng commented on a change in pull request #3468: Add a component tag for every pulsar function URL: https://github.com/apache/pulsar/pull/3468#discussion_r251668270 ########## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java ########## @@ -546,6 +546,7 @@ private V1StatefulSet createStatefulSet() { private Map getLabels(Function.FunctionDetails functionDetails) { final Map labels = new HashMap<>(); + labels.put("component", "function"); Review comment: Since we do make the distinction in the prometheus metrics exposed in the function instance. Pulsar sinks stats will be prefixed with "pulsar_sink", sources will be prefixed with "pulsar_source" and functions will be prefixed with "pulsar_function" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services