From commits-return-21347-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Mon Jan 28 20:59:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4252A18067A for ; Mon, 28 Jan 2019 20:59:08 +0100 (CET) Received: (qmail 96811 invoked by uid 500); 28 Jan 2019 19:59:07 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 96802 invoked by uid 99); 28 Jan 2019 19:59:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jan 2019 19:59:07 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] sijie commented on issue #3457: Do not set HierarchicalLedgerManagerFactory explicitly Message-ID: <154870554685.22084.3797663219178099582.gitbox@gitbox.apache.org> Date: Mon, 28 Jan 2019 19:59:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sijie commented on issue #3457: Do not set HierarchicalLedgerManagerFactory explicitly URL: https://github.com/apache/pulsar/issues/3457#issuecomment-458278863 @rdhabalia > Yes, I agree. So, can we keep LongHierarchical default option? we can use LongHierarchical as default option. however that is not very useful for zookeeper based metadata manager, because zookeeper's sequence id will not go beyond 2^32 :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services