From commits-return-21293-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Mon Jan 28 13:40:32 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E52B818060E for ; Mon, 28 Jan 2019 13:40:31 +0100 (CET) Received: (qmail 5751 invoked by uid 500); 28 Jan 2019 12:40:31 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 5738 invoked by uid 99); 28 Jan 2019 12:40:31 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jan 2019 12:40:31 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] ambition119 commented on a change in pull request #3456: Remove the judgment of the localrun mode (#3447) Message-ID: <154867923054.29279.14205311188174266373.gitbox@gitbox.apache.org> Date: Mon, 28 Jan 2019 12:40:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ambition119 commented on a change in pull request #3456: Remove the judgment of the localrun mode (#3447) URL: https://github.com/apache/pulsar/pull/3456#discussion_r251396066 ########## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java ########## @@ -205,23 +205,17 @@ public static void main(String[] args) throws Exception { } ++cmdPos; - boolean isLocalRun = cmdPos < args.length && "localrun".equals(args[cmdPos].toLowerCase()); Function adminFactory; Review comment: ```java Function adminFactory = (adminBuilder) -> { try { return adminBuilder.build(); } catch (Exception ex) { System.err.println(ex.getClass() + ": " + ex.getMessage()); System.exit(1); return null; } }; ``` Is this also possible? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services