From commits-return-20916-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Thu Jan 24 01:59:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id EDC0B1807A5 for ; Thu, 24 Jan 2019 01:59:03 +0100 (CET) Received: (qmail 58036 invoked by uid 500); 24 Jan 2019 00:59:03 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 57761 invoked by uid 99); 24 Jan 2019 00:59:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jan 2019 00:59:02 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] sijie commented on a change in pull request #3379: Issue #3378: [pulsar-io] Support Pulsar to receive and send data from Apache NiFi Message-ID: <154829154234.1843.17382912168943490911.gitbox@gitbox.apache.org> Date: Thu, 24 Jan 2019 00:59:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sijie commented on a change in pull request #3379: Issue #3378: [pulsar-io] Support Pulsar to receive and send data from Apache NiFi URL: https://github.com/apache/pulsar/pull/3379#discussion_r250427286 ########## File path: pulsar-io/nifi/src/main/java/org/apache/pulsar/io/nifi/NiFiSink.java ########## @@ -0,0 +1,141 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.io.nifi; + +import com.google.common.base.Preconditions; +import com.google.common.collect.Lists; +import lombok.extern.slf4j.Slf4j; +import org.apache.nifi.remote.Transaction; +import org.apache.nifi.remote.TransferDirection; +import org.apache.nifi.remote.client.SiteToSiteClient; +import org.apache.nifi.remote.client.SiteToSiteClientConfig; +import org.apache.pulsar.functions.api.Record; +import org.apache.pulsar.io.core.Sink; +import org.apache.pulsar.io.core.SinkContext; +import org.apache.pulsar.io.core.annotations.Connector; +import org.apache.pulsar.io.core.annotations.IOType; + +import java.io.IOException; +import java.util.List; +import java.util.Map; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; + + +/** + * A sink that delivers data to Apache NiFi using the NiFi Site-to-Site client. The sink requires + * a NiFiDataPacketBuilder which can create instances of NiFiDataPacket from the incoming data. + */ +@Connector( + name = "nifi", + type = IOType.SINK, + help = "The NiFiSink is used for moving messages from Pulsar to Apache NiFi using the NiFi Site-to-Site client.", + configClass = NiFiConfig.class +) +@Slf4j +public class NiFiSink implements Sink { + + private NiFiConfig niFiConfig; + private SiteToSiteClientConfig clientConfig; + private SiteToSiteClient client; + + private int requestBatchCount; + private long waitTimeMs; + private List> currentList; + private ScheduledExecutorService flushExecutor; + + @Override + public void open(Map config, SinkContext sinkContext) throws Exception { + niFiConfig = NiFiConfig.load(config); + Preconditions.checkNotNull(niFiConfig.getUrl(), "url property not set."); + Preconditions.checkNotNull(niFiConfig.getPortName(), "portName property not set."); + Preconditions.checkArgument(niFiConfig.getRequestBatchCount() > 0, + "requestBatchCount must be a positive integer."); + + clientConfig = new SiteToSiteClient.Builder() + .url(niFiConfig.getUrl()) + .portName(niFiConfig.getPortName()) + .requestBatchCount(niFiConfig.getRequestBatchCount()) + .buildConfig(); + client = new SiteToSiteClient.Builder().fromConfig(clientConfig).build(); + + + requestBatchCount = niFiConfig.getRequestBatchCount(); + waitTimeMs = niFiConfig.getWaitTimeMs(); + currentList= Lists.newArrayList(); + + flushExecutor = Executors.newScheduledThreadPool(1); + flushExecutor.scheduleAtFixedRate(() -> flush(), waitTimeMs, waitTimeMs, TimeUnit.MILLISECONDS); + } + + @Override + public void close() throws Exception { + if (null != client) { + client.close(); + } + + if (null != flushExecutor) { + flushExecutor.shutdown(); + } + + } + + @Override + public void write(Record record) { + int number; + synchronized (this) { + currentList.add(record); + number = currentList.size(); + } + + if (number == requestBatchCount) { + flushExecutor.schedule(() -> flush(), 0, TimeUnit.MILLISECONDS); + } + } + + private void flush() { + try { + final Transaction transaction = client.createTransaction(TransferDirection.SEND); Review comment: move line 115 to line 124? otherwise, we might create a `transaction` instance but do nothing if `currentList` is empty (line 119)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services