From commits-return-20642-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Fri Jan 18 02:39:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 239CE180663 for ; Fri, 18 Jan 2019 02:39:04 +0100 (CET) Received: (qmail 42685 invoked by uid 500); 18 Jan 2019 01:39:04 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 42671 invoked by uid 99); 18 Jan 2019 01:39:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Jan 2019 01:39:04 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] ambition119 commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink Message-ID: <154777554363.15988.33141108664987722.gitbox@gitbox.apache.org> Date: Fri, 18 Jan 2019 01:39:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ambition119 commented on a change in pull request #3368: Issue #3290 Pulsar IO connector for Hbase sink URL: https://github.com/apache/pulsar/pull/3368#discussion_r248902896 ########## File path: pulsar-io/hbase/src/main/java/org/apache/pulsar/io/hbase/HbaseAbstractConfig.java ########## @@ -0,0 +1,83 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.io.hbase; + +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.Setter; +import lombok.ToString; +import lombok.experimental.Accessors; +import org.apache.commons.lang.StringUtils; +import org.apache.pulsar.io.core.annotations.FieldDoc; + +import java.io.Serializable; + +/** + * Configuration object for all Hbase Sink components. + */ +@Data +@Setter +@Getter +@EqualsAndHashCode +@ToString +@Accessors(chain = true) +public class HbaseAbstractConfig implements Serializable { + + private static final long serialVersionUID = 6783394446906640112L; + + @FieldDoc( + required = false, + defaultValue = "", + help = "hbase system configuration 'hbase-site.xml' file") + private String hbaseConfigResources; + + @FieldDoc( + required = true, + defaultValue = "", + help = "hbase system configuration about hbase.zookeeper.quorum value") + private String zookeeperQuorum; + + @FieldDoc( + required = true, + defaultValue = "2181", + help = "hbase system configuration about hbase.zookeeper.property.clientPort value") + private String zookeeperClientPort = "2181"; + + @FieldDoc( + required = true, Review comment: > If the setting already has a default value, it is not required any more, no? ok ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services