From commits-return-20567-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Thu Jan 17 08:05:01 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1319F180663 for ; Thu, 17 Jan 2019 08:05:00 +0100 (CET) Received: (qmail 99497 invoked by uid 500); 17 Jan 2019 07:05:00 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 99474 invoked by uid 99); 17 Jan 2019 07:05:00 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jan 2019 07:05:00 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] merlimat commented on issue #3380: Issue #3373: RemotelyClosedException when running SampleProducer Message-ID: <154770869948.8728.15523293155901431126.gitbox@gitbox.apache.org> Date: Thu, 17 Jan 2019 07:04:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit merlimat commented on issue #3380: Issue #3373: RemotelyClosedException when running SampleProducer URL: https://github.com/apache/pulsar/pull/3380#issuecomment-455064503 > I also updated the caption and description of this pull request. ideally it would be good to provide enough context in both caption and description to make review easier, rather than just "fix issue #xyz". Yes, also we need to be careful when merging, because github will use the original message when doing the commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services