From commits-return-20356-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org  Fri Jan 11 09:03:14 2019
Return-Path: <commits-return-20356-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id E66B8180676
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 11 Jan 2019 09:03:13 +0100 (CET)
Received: (qmail 82184 invoked by uid 500); 11 Jan 2019 08:03:13 -0000
Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@pulsar.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@pulsar.apache.org>
List-Post: <mailto:commits@pulsar.apache.org>
List-Id: <commits.pulsar.apache.org>
Reply-To: dev@pulsar.apache.org
Delivered-To: mailing list commits@pulsar.apache.org
Received: (qmail 82175 invoked by uid 99); 11 Jan 2019 08:03:13 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Jan 2019 08:03:13 +0000
From: GitBox <git@apache.org>
To: commits@pulsar.apache.org
Subject: [GitHub] ambition119 edited a comment on issue #3294: [IO] [Kafka] a Kafka
 source submitted with invalid configuration stucks without consuming from
 Kafka topics
Message-ID: <154719379252.30020.5206239550282571614.gitbox@gitbox.apache.org>
Date: Fri, 11 Jan 2019 08:03:12 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

ambition119 edited a comment on issue #3294: [IO] [Kafka] a Kafka source submitted with invalid configuration stucks without consuming from Kafka topics
URL: https://github.com/apache/pulsar/issues/3294#issuecomment-453418838
 
 
   Use 'source create' command we validate the parameter key is included, but it does not verify that the value of the key is correct, so create sucessflully. If value is error, should we return the create source failure?
   kafka.yaml info:
   ```file
   configs:
       bootstrapServers: "xxxxxxx"
       groupId: "pulsarUTset"
       topic: "test_kafka_topic"
       fetchMinBytes: 1
       autoCommitEnabled: "true"
       autoCommitIntervalMs: 1000
       sessionTimeoutMs: 3000
   ```
   command like :
   ```shell
   ./bin/pulsar-admin source create --source-config-file ~/code/pulsar/pulsar_ms/file/kafka.yaml -t kafka --destination-topic-name dest_topic --name kafka_fn
   "Created successfully"
   ```
   when I getstatus return info: 
   ```shell
   $ ./bin/pulsar-admin source getstatus  --name kafka_fn
   {
     "numInstances" : 1,
     "numRunning" : 1,
     "instances" : [ {
       "instanceId" : 0,
       "status" : {
         "running" : true,
         "error" : "",
         "numRestarts" : 0,
         "numReceivedFromSource" : 0,
         "numSystemExceptions" : 0,
         "latestSystemExceptions" : [ ],
         "numSourceExceptions" : 0,
         "latestSourceExceptions" : [ ],
         "numWritten" : 0,
         "lastReceivedTime" : 0,
         "workerId" : "c-standalone-fw-localhost-8080"
       }
     } ]
   }
   ```
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services