From commits-return-19863-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Wed Jan 2 18:57:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1010418066C for ; Wed, 2 Jan 2019 18:57:35 +0100 (CET) Received: (qmail 21965 invoked by uid 500); 2 Jan 2019 17:57:35 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 21956 invoked by uid 99); 2 Jan 2019 17:57:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jan 2019 17:57:35 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] merlimat commented on a change in pull request #3273: Adding config auto.offset.reset to PulsarKafkaConsumer Message-ID: <154645185464.8011.9025454401113696231.gitbox@gitbox.apache.org> Date: Wed, 02 Jan 2019 17:57:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit merlimat commented on a change in pull request #3273: Adding config auto.offset.reset to PulsarKafkaConsumer URL: https://github.com/apache/pulsar/pull/3273#discussion_r244805463 ########## File path: pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java ########## @@ -65,6 +66,7 @@ @Slf4j public class PulsarKafkaConsumer implements Consumer, MessageListener { + private static enum OffsetResetStrategy {EARLIEST, LATEST, NONE} Review comment: Why not using directly `SubscriptionInitialPosition`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services