From commits-return-19858-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Wed Jan 2 18:03:45 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 06B9C18066C for ; Wed, 2 Jan 2019 18:03:44 +0100 (CET) Received: (qmail 28129 invoked by uid 500); 2 Jan 2019 17:03:44 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 28110 invoked by uid 99); 2 Jan 2019 17:03:44 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Jan 2019 17:03:44 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] ConcurrencyPractitioner commented on a change in pull request #3273: Adding config auto.offset.reset to PulsarKafkaConsumer Message-ID: <154644862353.4877.13061602087570994380.gitbox@gitbox.apache.org> Date: Wed, 02 Jan 2019 17:03:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ConcurrencyPractitioner commented on a change in pull request #3273: Adding config auto.offset.reset to PulsarKafkaConsumer URL: https://github.com/apache/pulsar/pull/3273#discussion_r244793847 ########## File path: pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java ########## @@ -159,6 +163,16 @@ private PulsarKafkaConsumer(ConsumerConfig config, Deserializer keyDeserializ } } + private OffsetResetStrategy getStrategy(final String strategy) { + if (strategy.equals("earliest")) { Review comment: Yeah, will change to the logic to take that into account. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services