pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tobgu commented on issue #3161: Message ID of sent message should be returned in Go client producer
Date Wed, 30 Jan 2019 06:24:08 GMT
tobgu commented on issue #3161: Message ID of sent message should be returned in Go client
producer
URL: https://github.com/apache/pulsar/issues/3161#issuecomment-458827134
 
 
   Would it not be strange to return an error when nothing failed? Or am I misunderstanding
something?
   
   I don't know which backwards compatibility promises you've made but to me it would make
most sense to have a signature like the this:
   ```go
   func (p *producer) Send(ctx context.Context, msg ProducerMessage) (MessageID, error)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message