pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tuteng commented on issue #3456: Remove the judgment of the localrun mode (#3447)
Date Tue, 29 Jan 2019 02:14:43 GMT
tuteng commented on issue #3456: Remove the judgment of the localrun mode (#3447)
URL: https://github.com/apache/pulsar/pull/3456#issuecomment-458380432
 
 
   https://github.com/apache/pulsar/blob/26c1f3d6e2728f0f9ba76c99060c7627003b4d07/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java#L113
   Is this a better place to handle admin is null? Initialize only some required classes.
@sijie 
   ```
   if (admin != null) {
       jcommander.addCommand(c.getKey(), c.getValue().getConstructor(PulsarAdmin.class).newInstance(admin));
   } else if (c.getKey().equals("functions") || c.getKey().equals("source") || c.getKey().equals("sink"))
{
       jcommander.addCommand(c.getKey(), c.getValue().getConstructor(PulsarAdmin.class).newInstance(admin));
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message