pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #3468: Add a component tag for every pulsar function
Date Tue, 29 Jan 2019 02:09:09 GMT
jerrypeng commented on a change in pull request #3468: Add a component tag for every pulsar
function
URL: https://github.com/apache/pulsar/pull/3468#discussion_r251668270
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java
 ##########
 @@ -546,6 +546,7 @@ private V1StatefulSet createStatefulSet() {
 
     private Map<String, String> getLabels(Function.FunctionDetails functionDetails)
{
         final Map<String, String> labels = new HashMap<>();
+        labels.put("component", "function");
 
 Review comment:
   Since we do make the distinction in the prometheus metrics exposed in the function instance.
 Pulsar sinks stats will be prefixed with "pulsar_sink", sources will be prefixed with "pulsar_source"
and functions will be prefixed with "pulsar_function"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message