pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tuteng commented on issue #3456: Remove the judgment of the localrun mode (#3447)
Date Tue, 29 Jan 2019 01:23:31 GMT
tuteng commented on issue #3456: Remove the judgment of the localrun mode (#3447)
URL: https://github.com/apache/pulsar/pull/3456#issuecomment-458369730
 
 
   > @tuteng :
   > 
   > > Admin client need to be built in both localrun mode and non-localrun mode.
   > 
   > I am not sure if that's the case. localrun invokes a script `bin/function-localrunner`
to fork a process and run the process. so I explicitly disable creating admin client when
localrun is used to avoid constructing unnecessary connections.
   > 
   > so I think the right fix is for CmdTopics to handle if admin is null https://github.com/apache/pulsar/blob/master/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java#L57
   
   I also think it's better. I handle if admin is null at first, but there are some problems
in it. I'll try it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message