pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on issue #3457: Do not set HierarchicalLedgerManagerFactory explicitly
Date Mon, 28 Jan 2019 23:59:51 GMT
merlimat commented on issue #3457: Do not set HierarchicalLedgerManagerFactory explicitly
URL: https://github.com/apache/pulsar/issues/3457#issuecomment-458351582
 
 
   > we can use LongHierarchical as default option. however that is not very useful for
zookeeper based metadata manager, because zookeeper's sequence id will not go beyond 2^32
:)
   
   @sijie  I'm actually a bit confused on the difference between `LongHierarchicalLedgerManagerFactory`
and `HierarchicalLedgerManager`. As I understand `HierarchicalLedgerManager` is already handling
the 64bit ledger id generation by having the 2 parts: 
   
   https://github.com/apache/bookkeeper/blob/e921193b464bc86b24fa63bb71ba85ebb2d523c6/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java#L34-L41
   
   @eolivelli is the BK client picking up the the ledger manager implementation from the ZK
metadata unless specified?
   
   One other part to be careful is the `pulsar initialize-cluster-metadata`. This is assuming
a pristine cluster. If there's already BK initialized, it might not initialize the required
Pulsar metadata.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message