pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ambition119 commented on a change in pull request #3456: Remove the judgment of the localrun mode (#3447)
Date Mon, 28 Jan 2019 12:37:43 GMT
ambition119 commented on a change in pull request #3456: Remove the judgment of the localrun
mode (#3447)
URL: https://github.com/apache/pulsar/pull/3456#discussion_r251396066
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java
 ##########
 @@ -205,23 +205,17 @@ public static void main(String[] args) throws Exception {
         }
 
         ++cmdPos;
-        boolean isLocalRun = cmdPos < args.length && "localrun".equals(args[cmdPos].toLowerCase());
 
         Function<PulsarAdminBuilder, ? extends PulsarAdmin> adminFactory;
 
 Review comment:
   ```java
   Function<PulsarAdminBuilder, ? extends PulsarAdmin> adminFactory  = (adminBuilder)
-> {
               try {
                   return adminBuilder.build();
               } catch (Exception ex) {
                   System.err.println(ex.getClass() + ": " + ex.getMessage());
                   System.exit(1);
                   return null;
               }
           };
   ```
   Is this also possible?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message