pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #3428: Add support for pluggable jvm-metrics
Date Fri, 25 Jan 2019 05:05:19 GMT
jerrypeng commented on a change in pull request #3428: Add support for pluggable jvm-metrics
URL: https://github.com/apache/pulsar/pull/3428#discussion_r250867973
 
 

 ##########
 File path: conf/broker.conf
 ##########
 @@ -567,6 +567,9 @@ exposeTopicLevelMetricsInPrometheus=true
 # Enable consumer level metrics. default is false
 exposeConsumerLevelMetricsInPrometheus=false
 
+# Classname of Pluggable JVM GC metrics logger that can log GC specific metrics
+jvmGCMetricsLoggerClassName=java.lang.management.ManagementFactory.JvmG1GCMetricsLogger
 
 Review comment:
   so why is the default "JvmG1GCMetricsLogger"? and not "JvmDefaultGCMetricsLogger.java"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message