pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ambition119 commented on a change in pull request #3418: Some minor fixes in Kafka-IO and Client-Cli
Date Fri, 25 Jan 2019 01:33:36 GMT
ambition119 commented on a change in pull request #3418: Some minor fixes in Kafka-IO and Client-Cli
URL: https://github.com/apache/pulsar/pull/3418#discussion_r250839809
 
 

 ##########
 File path: pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSinkConfig.java
 ##########
 @@ -60,7 +60,7 @@
             "The batch size that Kafka producer will attempt to batch records together before
sending them to brokers.")
     private long batchSize = 16384L;
     @FieldDoc(
-        defaultValue = "16384",
+        defaultValue = "1048576",
 
 Review comment:
   long type value is 1048576L, so defaultValue is 1048576l or 1048576L. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message