pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ambition119 commented on a change in pull request #3401: [Issue #3369] fix kafka ProducerExample and ConsumerExample IndexOutOfBoundsException
Date Thu, 24 Jan 2019 02:00:11 GMT
ambition119 commented on a change in pull request #3401: [Issue #3369] fix kafka ProducerExample
and ConsumerExample IndexOutOfBoundsException
URL: https://github.com/apache/pulsar/pull/3401#discussion_r250440710
 
 

 ##########
 File path: pulsar-client-kafka-compat/pulsar-client-kafka-tests/src/test/java/org/apache/pulsar/client/kafka/compat/examples/ConsumerExample.java
 ##########
 @@ -23,7 +23,7 @@
 
 import org.apache.kafka.clients.consumer.Consumer;
 import org.apache.kafka.clients.consumer.ConsumerRecords;
-import org.apache.kafka.clients.consumer.KafkaConsumer;
+import org.apache.kafka.clients.consumer.PulsarKafkaConsumer;
 
 Review comment:
   > I don't think you should change the constructor. but you can still change the topic
to ` "persistent://public/default/test"`
   
   I think org.apache.kafka.clients.consumer.PulsarKafkaConsumer would be better renamed org.apache.pulsar.kafka.clients.consumer.PulsarKafkaConsumer.
 
   The naming of shade coincides with the naming of native kafka,  which leads to confusion.
   [shadedPattern](https://github.com/apache/pulsar/blob/master/pulsar-client-kafka-compat/pulsar-client-kafka-shaded/pom.xml#L133)
   Why not follow the usual shade name here?  
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message