pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] lovelle opened a new pull request #3403: [Issue #3226][cpp client] Prevent dup consumers on same client cnx
Date Tue, 22 Jan 2019 22:18:06 GMT
lovelle opened a new pull request #3403: [Issue #3226][cpp client] Prevent dup consumers on
same client cnx
URL: https://github.com/apache/pulsar/pull/3403
 
 
   Prevent same consumer subscription over the same client connection for cpp
   client. For more details please see explanation on commit 44e1a23.
   
   ### Motivation
   
   Fix #3226 for cpp client.
   
   ### Modifications
   
   Add check for `ClientImpl.cc` to know whether new shared consumer subscribe is already
present
   on consumers vector or not.
   
   For further explanation please see #3312 
   
   ### Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Add unit test asserting if duplicated consumers are allowed for shared
       subscription.
     - Add test preventing broker metadata error by closing a duplicate consumer
       over the same connection.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API: (yes / **no**).
     - The schema: (yes / **no** / don't know)
     - The default values of configurations: (yes / **no**)
     - The wire protocol: (yes / **no**)
     - The rest endpoints: (yes / **no**)
     - The admin cli options: (yes / **no**)
     - Anything that affects deployment: (yes / **no** / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding
the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message