pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #3383: refactor AuthorizationProvider interface to allow custom logic for determining super user
Date Sat, 19 Jan 2019 22:42:50 GMT
sijie commented on a change in pull request #3383:  refactor AuthorizationProvider interface
to allow custom logic for determining super user
URL: https://github.com/apache/pulsar/pull/3383#discussion_r249259707
 
 

 ##########
 File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationProvider.java
 ##########
 @@ -35,6 +35,14 @@
  */
 public interface AuthorizationProvider extends Closeable {
 
+    /**
+     * Check if specified role is a super user
+     * @param role the role to check
+     * @return a CompletableFuture containing a boolean in which true means the role is a
super user
+     * and false if it is not
+     */
+    CompletableFuture<Boolean> isSuperUser(String role);
 
 Review comment:
   hmm, what you are saying here is this is a semantic breaking change?  
   
   if that's case, can we still maintain semantic BC before breaking it? for example, you
can deprecate the superUserRoles setting, but not change the semantic. so if superUserRoles
is set, use the setting and maintain the BC behavior; if superUserRoles is not set, then use
the new behavior. 
   
   If you don't want to maintain the semantic BC, then you should highlight the BC changes
somewhere and document what users should do when upgrading to 2.3.0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message