pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ambition119 commented on a change in pull request #3379: Issue #3378: [pulsar-io] Support Pulsar to receive and send data from Apache NiFi
Date Fri, 18 Jan 2019 04:15:51 GMT
ambition119 commented on a change in pull request #3379: Issue #3378: [pulsar-io] Support Pulsar
to receive and send data from Apache NiFi 
URL: https://github.com/apache/pulsar/pull/3379#discussion_r248923756
 
 

 ##########
 File path: pulsar-io/nifi/src/main/java/org/apache/pulsar/io/nifi/NiFiSink.java
 ##########
 @@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.io.nifi;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.nifi.remote.Transaction;
+import org.apache.nifi.remote.TransferDirection;
+import org.apache.nifi.remote.client.SiteToSiteClient;
+import org.apache.nifi.remote.client.SiteToSiteClientConfig;
+import org.apache.pulsar.functions.api.Record;
+import org.apache.pulsar.io.core.Sink;
+import org.apache.pulsar.io.core.SinkContext;
+import org.apache.pulsar.io.core.annotations.Connector;
+import org.apache.pulsar.io.core.annotations.IOType;
+
+import java.io.IOException;
+import java.util.Map;
+
+
+/**
+ * A sink that delivers data to Apache NiFi using the NiFi Site-to-Site client. The sink
requires
+ * a NiFiDataPacketBuilder which can create instances of NiFiDataPacket from the incoming
data.
+ */
+@Connector(
+    name = "nifi",
+    type = IOType.SINK,
+    help = "The NiFiSink is used for moving messages from Pulsar to Apache NiFi using the
NiFi Site-to-Site client.",
+    configClass = NiFiConfig.class
+)
+@Slf4j
+public class NiFiSink implements Sink<NiFiDataPacket> {
+
+    private NiFiConfig niFiConfig;
+    private SiteToSiteClient client;
+    private SiteToSiteClientConfig clientConfig;
+
+    @Override
+    public void open(Map<String, Object> config, SinkContext sinkContext) throws Exception
{
+        niFiConfig = NiFiConfig.load(config);
+        if (niFiConfig.getUrl() == null
 
 Review comment:
   > I would encourage using guava preconditions and check individual arguments. this would
allow you providing clear error messages.
   > 
   > ```
   > checkNotNull(niFiConfig.getUrl(), "No NiFi URL is provided");
   > checkNotNull(niFiConfig.getPortName(), "No NiFi port name is provided");
   > checkArgument(niFiConfig.getRequestBatchCount() > 0, "Positive request batch count
is required");
   > ```
   
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message