pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #3365: create_topic_with_check_namespaces_cluster
Date Thu, 17 Jan 2019 07:22:49 GMT
sijie commented on a change in pull request #3365: create_topic_with_check_namespaces_cluster
URL: https://github.com/apache/pulsar/pull/3365#discussion_r248560422
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
 ##########
 @@ -129,11 +129,14 @@ public void revokePermissionsOnTopic(@PathParam("tenant") String tenant,
     @ApiResponses(value = {
         @ApiResponse(code = 403, message = "Don't have admin permission"),
         @ApiResponse(code = 409, message = "Partitioned topic already exist"),
-        @ApiResponse(code = 412, message = "Partitioned topic name is invalid")
+        @ApiResponse(code = 412, message = "Partitioned topic name is invalid"),
+        @ApiResponse(code = 24, message = "Namespace does not have any clusters configured"),
 
 Review comment:
   @foreversunyao I am a bit confused about `24` and `36` here?
   
   isn't `Precondition Failed` 412? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message