pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #3348: Remove broker mode to handle persistent/non-persistent topics separately
Date Sun, 13 Jan 2019 01:23:21 GMT
sijie commented on a change in pull request #3348: Remove broker mode to handle persistent/non-persistent
topics separately
URL: https://github.com/apache/pulsar/pull/3348#discussion_r247331067
 
 

 ##########
 File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
 ##########
 @@ -385,18 +385,6 @@
         doc = "Number of worker threads to serve non-persistent topic")
     private int numWorkerThreadsForNonPersistentTopic = Runtime.getRuntime().availableProcessors();;
 
-    @FieldContext(
-        category = CATEGORY_SERVER,
-        doc = "Enable broker to load persistent topics"
-    )
-    private boolean enablePersistentTopics = true;
 
 Review comment:
   one general question - should we deprecate the settings first in one release then remove
them in a later release? my general concern is suddenly removing configuration keys from one
release usually tends to surprise people, especially when things are not well documented

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message