pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #3299: Cleanup consumer subscriptions and fix graceful shutdown for functions/sinks
Date Fri, 11 Jan 2019 06:58:21 GMT
jerrypeng commented on a change in pull request #3299:  Cleanup consumer subscriptions and
fix graceful shutdown for functions/sinks
URL: https://github.com/apache/pulsar/pull/3299#discussion_r247017787
 
 

 ##########
 File path: pulsar-functions/proto/src/main/proto/Function.proto
 ##########
 @@ -98,6 +98,7 @@ message SourceSpec {
      * already present in the server */
     string builtin = 8;
     string subscriptionName = 9;
+    bool cleanupSubscription = 11;
 
 Review comment:
   @srkukarni I purposely designed the flag this way for backwards compatibility purposes.
 A function that is running with an older version of the code/metadata will still not cleanup
subscriptions as that was the behavior before

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message