pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #3299: Cleanup consumer subscriptions and fix graceful shutdown for functions/sinks
Date Fri, 11 Jan 2019 06:56:11 GMT
jerrypeng commented on a change in pull request #3299:  Cleanup consumer subscriptions and
fix graceful shutdown for functions/sinks
URL: https://github.com/apache/pulsar/pull/3299#discussion_r247017509
 
 

 ##########
 File path: pulsar-functions/proto/src/main/proto/Function.proto
 ##########
 @@ -98,6 +98,7 @@ message SourceSpec {
      * already present in the server */
     string builtin = 8;
     string subscriptionName = 9;
+    bool cleanupSubscription = 11;
 
 Review comment:
   @srkukarni I am setting the Sink and Function config on the worker side to default to true
via the SinkConfigUtils and FunctionConfigUtils.  Also this property is not relevant to Sources

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message