pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ambition119 commented on a change in pull request #3339: issues #3264 fix partitioned-stats reporting errors not match
Date Thu, 10 Jan 2019 03:53:36 GMT
ambition119 commented on a change in pull request #3339: issues #3264 fix partitioned-stats
reporting errors not match
URL: https://github.com/apache/pulsar/pull/3339#discussion_r246629705
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java
 ##########
 @@ -798,7 +798,6 @@ public void partitionedTopics(String topicName) throws Exception {
 
         try {
             admin.topics().getPartitionedStats(partitionedTopicName, false);
-            fail("should have failed");
 
 Review comment:
   > This line deletion makes the test block no mean. How about add some comments of the
expected stats result, and verify it is output as expected.
   
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message