pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #3345: Propagate specific Schema error to client
Date Thu, 10 Jan 2019 00:21:44 GMT
sijie commented on a change in pull request #3345: Propagate specific Schema error to client
URL: https://github.com/apache/pulsar/pull/3345#discussion_r246599101
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -138,6 +138,8 @@ enum ServerError {
 
     ProducerBusy         = 16; // Producer with same name is already connected
     InvalidTopicName = 17; // The topic name is not valid
+
+    IncompatibleSchema = 18; // Specified schema was incompatible with topic schema
 
 Review comment:
   do you need to bump the api version? if an old client talks to new brokers, what is the
behavior after this change? shall we just respond with BrokerServiceException?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message