pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] liketic commented on a change in pull request #3307: Remove --global-zookeeper completely
Date Wed, 09 Jan 2019 01:00:53 GMT
liketic commented on a change in pull request #3307: Remove --global-zookeeper completely
URL: https://github.com/apache/pulsar/pull/3307#discussion_r246222248
 
 

 ##########
 File path: bin/pulsar
 ##########
 @@ -297,11 +297,6 @@ elif [ $COMMAND == "bookie" ]; then
 elif [ $COMMAND == "zookeeper" ]; then
     PULSAR_LOG_FILE=${PULSAR_LOG_FILE:-"zookeeper.log"}
     exec $JAVA ${ZK_OPTS} $OPTS $ASPECTJ_AGENT -Dpulsar.log.file=$PULSAR_LOG_FILE org.apache.pulsar.zookeeper.ZooKeeperStarter
$PULSAR_ZK_CONF $@
-elif [ $COMMAND == "global-zookeeper" ]; then
 
 Review comment:
   Thanks @merlimat , I opened #3338 for removing from codebase. And the command ```global-zookeeper```
won't be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message