pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #3307: Remove --global-zookeeper completely
Date Mon, 07 Jan 2019 19:27:01 GMT
merlimat commented on a change in pull request #3307: Remove --global-zookeeper completely
URL: https://github.com/apache/pulsar/pull/3307#discussion_r245770047
 
 

 ##########
 File path: bin/pulsar
 ##########
 @@ -297,11 +297,6 @@ elif [ $COMMAND == "bookie" ]; then
 elif [ $COMMAND == "zookeeper" ]; then
     PULSAR_LOG_FILE=${PULSAR_LOG_FILE:-"zookeeper.log"}
     exec $JAVA ${ZK_OPTS} $OPTS $ASPECTJ_AGENT -Dpulsar.log.file=$PULSAR_LOG_FILE org.apache.pulsar.zookeeper.ZooKeeperStarter
$PULSAR_ZK_CONF $@
-elif [ $COMMAND == "global-zookeeper" ]; then
 
 Review comment:
   I think we should leave these commands for backward compatibilty. Of course the documentation
will only cover the "preferred" naming, but these should provide no confusion here since they're
pretty much hidden.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message