pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] liketic commented on a change in pull request #3308: Add heartbeat interval for kafka connector
Date Sat, 05 Jan 2019 14:21:08 GMT
liketic commented on a change in pull request #3308: Add heartbeat interval for kafka connector
URL: https://github.com/apache/pulsar/pull/3308#discussion_r245479065
 
 

 ##########
 File path: pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java
 ##########
 @@ -69,6 +69,11 @@
         help =
             "The timeout used to detect failures when using Kafka's group management facilities.")
     private long sessionTimeoutMs = 30000L;
+    @FieldDoc(
+        defaultValue = "3000",
+        help =
+            "The interval between heartbeats to the consumer when using Kafka's group management
facilities.")
 
 Review comment:
   Thanks! I pushed 6e497c1d30bc7de2780822da69c1cfb3ffc86cc0 , please review again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message