pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] erenavsarogullari commented on a change in pull request #3295: issue #3276 Pulsar IO connector for udp source
Date Thu, 03 Jan 2019 22:34:57 GMT
erenavsarogullari commented on a change in pull request #3295:  issue #3276 Pulsar IO connector
for udp source
URL: https://github.com/apache/pulsar/pull/3295#discussion_r245142798
 
 

 ##########
 File path: pulsar-io/netty/src/main/java/org/apache/pulsar/io/netty/server/NettyServer.java
 ##########
 @@ -99,8 +133,8 @@ public Builder setPort(int port) {
             return this;
         }
 
-        public Builder setNettyTcpSource(NettyTcpSource nettyTcpSource) {
-            this.nettyTcpSource = nettyTcpSource;
+        public Builder setNettyTcpSource(NettySource nettySource) {
 
 Review comment:
   `setNettyTcpSource` can be renamed as `setNettySource`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message