pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ConcurrencyPractitioner commented on a change in pull request #3273: Adding config auto.offset.reset to PulsarKafkaConsumer
Date Wed, 02 Jan 2019 17:05:51 GMT
ConcurrencyPractitioner commented on a change in pull request #3273: Adding config auto.offset.reset
to PulsarKafkaConsumer
URL: https://github.com/apache/pulsar/pull/3273#discussion_r244794429
 
 

 ##########
 File path: pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java
 ##########
 @@ -159,6 +163,16 @@ private PulsarKafkaConsumer(ConsumerConfig config, Deserializer<K>
keyDeserializ
         }
     }
 
+    private OffsetResetStrategy getStrategy(final String strategy) {
+    	if (strategy.equals("earliest")) {
+    		return OffsetResetStrategy.EARLIEST;
+    	} else if (strategy.equals("latest")) {
+    		return OffsetResetStrategy.LATEST;
+    	} else {
 
 Review comment:
   Oh, actually in Kafka, OffsetResetStrategy.NONE in fact is a viable option for users. In
this case, if its NONE when the offset has an invalid position, KafkaConsumer will throw an
error. I forgot to replicate this behavior in the code. Will have to do that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message